fix: include underscore SPA chunks in embed#13
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes embedded (single-binary) deployments by ensuring Vite-generated SPA chunks whose filenames begin with _ (e.g. _authenticated-*.js) are included in the Go embed.FS, preventing the SPA fallback from incorrectly serving index.html (HTML MIME) for missing JS modules after login.
Changes:
- Update
//go:embedpattern fromdist/*toall:distso underscore-/dot-prefixed build artifacts are embedded. - Ensure authenticated-route code-split chunks are served as actual JS instead of falling back to
index.html(avoids strict MIME module load failures / post-login 500).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12